Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr: do not require NOTIFY_TYPES in python modules #57106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mgr: do not require NOTIFY_TYPES in python modules #57106

wants to merge 1 commit into from

Commits on Apr 26, 2024

  1. mgr: do not require NOTIFY_TYPES in python modules 

    Many python mgr modules lack a NOTIFY_TYPES member apparently without
any downsides beyond an annoying message in the logs.  This includes
commonly used mgr modules like 'volumes' and 'cephadm'.  Stop emitting
an error for missing NOTIFY_TYPES by not assuming all mgr modules in
python should provide it. The return code is also changed to indicate
that this is not an error but the return from this function is never
checked and so it should have no impact. However, if someone started
using the return value in the future this would match the log change.

Fixes: https://tracker.ceph.com/issues/55835
Signed-off-by: John Mulligan <jmulligan@redhat.com>
    @phlogistonjohn
    phlogistonjohn committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4589c4d View commit details
    Browse the repository at this point in the history