Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blk/bluestore: remove BlockDevice::supported_bdev_label() #57103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aclamk
Copy link
Contributor

@aclamk aclamk commented Apr 26, 2024

Block device got this interface function with #7145.
In bluestore, bdev label just means "first disk block, located at #0".
For other devices, there is deeper meaning: https://docs.pmem.io/ndctl-user-guide/managing-label-storage-areas-lsa

It is most likely that two distinct features were joined by name.
It is obvious that any block device will be able to write to its first block.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Block device got this interface function with ceph#7145.
In bluestore, bdev label just means "first disk block, located at #0".
For other devices, there is deeper meaning: https://docs.pmem.io/ndctl-user-guide/managing-label-storage-areas-lsa

It is most likely that two distinct features were joined by name.
It is obvious that any block device will be able to write to its first block.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
@aclamk aclamk force-pushed the wip-aclamk-bdev-remove-supported-bdev-label branch from f778349 to 6305a81 Compare April 26, 2024 10:51
@ifed01
Copy link
Contributor

ifed01 commented Apr 26, 2024

It looks to me that at least for NVMEDevice the path BlueStore uses doesn't refer to a block device under /dev but rather some spdk config file - see NVMEDevice::open(const string& p).
Hence one shouldn't write to the first block of this "device" file and supported_bdev_label() was intended to handle that.

@aclamk
Copy link
Contributor Author

aclamk commented Apr 29, 2024

It looks to me that at least for NVMEDevice the path BlueStore uses doesn't refer to a block device under /dev but rather some spdk config file - see NVMEDevice::open(const string& p).
Hence one shouldn't write to the first block of this "device" file and supported_bdev_label() was intended to handle that.

Right!
It means this PR depends on a9be5e2 .
We need to read bdev through bdev API, not with posix hacks.

@aclamk aclamk added the DNM label May 14, 2024
@aclamk
Copy link
Contributor Author

aclamk commented May 14, 2024

DNM until rebased on reading label through bdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants