Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting early for initial reviewing. Some parts can be split from this large PR into smaller pieces.
Notable changes:
internal/rbd_types
package with interfaces so that objects can be passed around cleanerinternal/rbd/volume.go
implementing the newVolume
interface forrbdImage
internal/rbd_group
package for all RBD-group functionalitiesinternal/rbd/group_controller.go
for all CSI VolumeGroup service proceduresCommits in the current form will mostly change majorly. Reviewing per commit is not recommended, only check the files that you are interested in 馃槈
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelatedfailure (please report the failure too!)