Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: VolumeGroupSnapshot support #4502

Draft
wants to merge 5 commits into
base: devel
Choose a base branch
from

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Mar 15, 2024

Posting early for initial reviewing. Some parts can be split from this large PR into smaller pieces.

Notable changes:

  • internal/rbd_types package with interfaces so that objects can be passed around cleaner
  • internal/rbd/volume.go implementing the new Volume interface for rbdImage
  • internal/rbd_group package for all RBD-group functionalities
  • internal/rbd/group_controller.go for all CSI VolumeGroup service procedures

Commits in the current form will mostly change majorly. Reviewing per commit is not recommended, only check the files that you are interested in 馃槈


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/rbd Issues related to RBD label Mar 15, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rbd Issues related to RBD stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant