Adding jenkins job for maintainer tool #2068
Conversation
|
Can one of the admins verify this patch? |
ceph-maintainer-tool/build/build
Outdated
| cat > maintainer-tool.py | ||
| mkdir maintainer-tool | ||
| cd maintainer-tool |
There was a problem hiding this comment.
Why are these lines here? What are they for?
ceph-maintainer-tool/build/build
Outdated
| cd ceph-maintainer-tool | ||
| cp maintainer-tool.py ../../maintainer-tool.py | ||
| rm -rf .git* | ||
| cd .. | ||
| rmdir -r ceph-maintainer-tool | ||
| cd .. | ||
| rmdir maintainer-tool |
There was a problem hiding this comment.
Why are you doing all this moving things around?
ceph-maintainer-tool/build/build
Outdated
| rmdir -r ceph-maintainer-tool | ||
| cd .. | ||
| rmdir maintainer-tool | ||
| python maintainer-tool.py src/pybind/mgr/ |
There was a problem hiding this comment.
Where is the scanned repo coming from?
| block-upstream: false | ||
| scm: | ||
| - git: | ||
| url: git@github.com:ceph/ceph.git |
There was a problem hiding this comment.
So this job will only be scanning ceph?
Seems like it makes this job less flexible. Is that what you want?
There was a problem hiding this comment.
My approach was to clone the maintainer tool repo and to get the script and run it against the ceph repo.
To test it on my local machine I tried to get this approach.
If there is any other suggestion could you please let me know.
deepalik21
force-pushed
the
ceph-maintainer-tool-build
branch
from
ce5174d
to
ddfd63e
Compare
ceph-maintainer-tool/build/build
Outdated
| TEMPVENV=$(create_venv_dir) | ||
| VENV=${TEMPVENV}/bin | ||
|
|
||
| source $VENV/activate |
There was a problem hiding this comment.
don't think we need to source the venv, and when I tried to execute this on the jenkins, it failed
| - ../../../scripts/build_utils.sh | ||
| - ../../build/build |
There was a problem hiding this comment.
I think we need this file to be in config/definitions/, and then this relative pathing should work
deepalik21
force-pushed
the
ceph-maintainer-tool-build
branch
from
ddfd63e
to
07ed446
Compare
Signed-off-by: Deepali Kasture <dkasture@redhat.com>
deepalik21
force-pushed
the
ceph-maintainer-tool-build
branch
from
07ed446
to
6461f5e
Compare
Signed-off-by: Deepali Kasture <dkasture@redhat.com>
deepalik21
force-pushed
the
ceph-maintainer-tool-build
branch
from
80293e4
to
f8335db
Compare
and fix whitespace
run on small trustys
Signed-off-by: Deepali Kasture dkasture@redhat.com