Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud Resource ID #46

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add Cloud Resource ID #46

wants to merge 4 commits into from

Conversation

thehappydinoa
Copy link
Member

@thehappydinoa thehappydinoa commented Oct 3, 2023 •
edited

  • Added Cloud Resource ID field to connectors
  • Added Created At timestamp where applicable

@thehappydinoa thehappydinoa changed the title Adh/cloud-resource-id Add Cloud Resource ID Oct 3, 2023
@thehappydinoa thehappydinoa self-assigned this Oct 3, 2023
@thehappydinoa thehappydinoa added the enhancement New feature or request label Oct 3, 2023
ericbutera
ericbutera requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ericbutera ericbutera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work! It should be pretty easy to merge with the in flight multiprocessing work. As this PR stands today, there are some significant merge conflicts with https://github.com/censys/censys-cloud-connector/blob/2df01cf29124ee1162e49c38c80b761eb0dab10b/src/censys/cloud_connectors/aws_connector/connector.py. I can figure out merging later next week when I get back to this work (currently working on bugs).

@thehappydinoa
Copy link
Member Author

thehappydinoa commented Oct 3, 2023 •
edited

@ericbutera that sounds perfect, I was just about to push up some various test fixes. I think I will push the ones up for the base classes, but not the aws one particularly. Hopefully this works and if we run into any issues next week please let me know, I am happy to help resolve/rebase where needed. Thanks! Also I am going to keep it in draft form so it doesn't accidentally get merged.

@thehappydinoa thehappydinoa added the do not merge This PR is not ready to be merged label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbutera ericbutera ericbutera requested changes

@dcaponi-censys dcaponi-censys dcaponi-censys approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@ericbutera ericbutera

@thehappydinoa thehappydinoa

Labels
do not merge This PR is not ready to be merged enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thehappydinoa @ericbutera @dcaponi-censys