Fix typo found by codespell - API breaking change #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DimitriPapadopoulos ! import warnings
....
def may_interfer(self, dsts, src):
warnings.warn("This api is deprecated, use `may_interfere` instead")
return self.may_interfere(dsts, src)Can you add it to the PR or may I fir your PR @DimitriPapadopoulos ? |
DimitriPapadopoulos
force-pushed
the
interfer
branch
from
ba14ad0
to
0f12fa6
Compare
|
@DimitriPapadopoulos : Can you rebase this pr? |
DimitriPapadopoulos
force-pushed
the
interfer
branch
from
0f12fa6
to
6084ae9
Compare
DimitriPapadopoulos
force-pushed
the
interfer
branch
from
6084ae9
to
1ba37c3
Compare
Add drepecation warning, arguments as suggested here: https://dev.to/hckjck/python-deprecation-2mof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.