Improved basic block manipulation #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nofiv, |
|
@nofiv could you please add a couple tests for these BB manipulation improvements? |
|
Sorry for this, but we haven't taken time to analyze the new interface introduced by the PR (shame on me). Maybe we have to this before any rebase. |
|
I'd like to know whether you want to add-in such a feature in the first place. If you want to, I'll create the tests and solve possible bugs (I'm not sure whether this version moved call instructions correctly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfyingly solves #961 for x86 architecture. Other architectures could be implemented later on.