New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] add pdf.js@1.3.22 with npm auto-update #5993
Conversation
@Amomo why not use git auto-update? |
We could get this library from its distribute GitHub repo and also npm. |
@Amomo thank you, could you rebase the PR? |
17e3c31
to
80bb379
Compare
@maruilian11 I have updated my PR, pdf.js has v1.2.61 now. |
@Amomo i think this pr is ok, could you rebase it to the master? thank you~ |
@maruilian11 I have rebase this PR, could you check again? Thank you! :-D |
@PeterDaveHello i think this PR is ok. |
Do we really need the |
Hi @Amomo, According to the code in pdf.js, it loads the worker.js file like this:
which means that if the minified pdf.js file is named |
@razorman8669 this advice is very important! Thank you very much! :-D @maruilian11 As @razorman8669 said, I add |
@Amomo as Peter said, maybe the files under |
Hi @yurydelendik |
There is an issue that did not let us to do it in first place: web workers cannot be loaded from the remote location. So people are using See also mozilla/pdf.js#5490. After mozilla/pdf.js#6571 lands, I will try to create a "proxy" page that will host cdn worker as well.
both, the web/ folder contains viewer parts, but PDF.js core library is located at build/ |
@yurydelendik Thank you. cc @cdnjs/team-cdnjs |
Suggested solution at: |
Is it possible to update pdf.js to use its newer version in the PR? |
Yes, of course, maybe we can add them both. |
Hi @maruilian11
For #5020, I add pdf.js at v1.1.539 and add
npm
auto-update config in its package.json.repo: https://github.com/mozilla/pdf.js
They put build files in another repo pdfjs-dist
I think we could add the whole repo because it is a distribution repository.
That's why I use
"**/*.+(js|css|svg|gif|png)"
in auto-update config.Would you mind checking this PR for me? Thank you~ :-D
654
, Star12,729
, Fork2,964