Cdkize cdks website #115
Open
Cdkize cdks website #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Call for help on slack re: cdkizing the site and providing a way to generate a slack invite url on demand
Description of changes: Note: this is incomplete... hard for me to go further without access I don't have (AWS Account / slack admin). I'm not asking for that but this should get you very close. I cdk -ized the site... created a distribution bucket / cloud front distribution + lambda that will redirect to a slack invite link. If you set up whatever secrets are needed in a secure string in parameter store (cheaper / should be within limits vs secrets manager) you can finish the
cdk/slack-join.tslambda to make that call and finish the redirect. A custom resource uploads a config.json file with the lambda's function url... react requests that and uses that as the invite link.Happy to make any changes and/or collaborate as needed.
Note: I generally try to avoid yarn but used it here since the repo used it... so I'm certain I'm not following yarn best practices 馃槄
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
cc: @mbonig