[feat] - Add async serdes.deserialize support & req/res as context #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Leverage ajv /asyc in serdes deserialization. - Leverage passContext for format.validate, deserialize, serialize - Add tests for async and context - Allow HttpErrors thrown from deserialize to influence errors thrown to express error handling pipeline. - Modify schema pre-processor to not share memory between ajv instance and apiDoc. - Modify schema pre-processor to not share memory between request and response apiDoc.
…re test coverage for async-utils.
…rows HttpErrors. Deviates when deserialization is occuring in query/body/params. Functionality is a no-op if package consumers throw an Ajv.ValidationError from their deserialize function instead of an HttpError.
…o didn't have tests.
…chema. Make sure the schema passsed to compile has if it needs it. Additionally add test coverage, and make sure the ajv instance used for preprocessing respects passContext config for validateRequests.
…el schema has a dscriminator would lose the /body prefix of the instancePath, making error messages inconsistent. Additionally, respect the actual class type of an HttpError thrown from a deserialize/validate function.
…he provided discriminator property value.
…e request if those properties are not set in data.
…so it shows up in errorCode.
| B-->C["Multi-part parsing / validation"]; | ||
| C-->D["Security enforcement"]; | ||
| D-->E["Request validation"]; | ||
| E-->F["Response validation"]; |
There was a problem hiding this comment.
This seems off; how can a response be validated before a handler has an opportunity to generate it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cdimascio
Add test coverage:
Full run pass:
