-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ switch to mqt-core
Python package
#336
Open
burgholzer
wants to merge
2
commits into
main
Choose a base branch
from
mqt-core-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
minor
Part of a minor release
packaging
Anything related to Python packaging
usability
Anything related to usability
labels
Jan 27, 2024
burgholzer
force-pushed
the
mqt-core-switch
branch
2 times, most recently
from
January 27, 2024 14:14
7ffac4c
to
ee41104
Compare
4 tasks
burgholzer
force-pushed
the
mqt-core-switch
branch
from
January 29, 2024 22:03
ee41104
to
8209611
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
+ Coverage 92.7% 92.9% +0.1%
=======================================
Files 35 35
Lines 2660 2666 +6
Branches 345 345
=======================================
+ Hits 2468 2477 +9
+ Misses 192 189 -3
|
burgholzer
force-pushed
the
mqt-core-switch
branch
2 times, most recently
from
February 5, 2024 22:10
a2ef802
to
2d2c358
Compare
4 tasks
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
force-pushed
the
mqt-core-switch
branch
from
February 14, 2024 15:28
2d2c358
to
61996fd
Compare
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
force-pushed
the
mqt-core-switch
branch
from
February 14, 2024 16:18
61996fd
to
60cd68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
minor
Part of a minor release
packaging
Anything related to Python packaging
python
Pull requests that update Python code
usability
Anything related to usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the project to use the newly developed
mqt-core
Python package.As part of this change, it switches from purely using the git submodule to using
FetchContent
(as advised in cda-tum/mqt-qcec#302), which also allows to use the libraries directly provided by the mqt-core Python package.This means that any Python package build will only require the
mqt-core
package as a build and runtime dependency and won't have to rely on the git submodule (or a fetched version of mqt-core) any more.Any regular C++ build will use the
FetchContent
CMake module.The change brings a range of advantages:
load
function ofmqt-core
that allows to load any supported circuit format as input and has better handling for QiskitQuantumCircuit
objects.Checklist: