-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(okx): default to public watchOrderBook #22401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pcriadoperez
commented
May 5, 2024
•
edited
edited
- brought up by issue ccxtpro bug: the watched ohlcvs cache in OKX exchange not updated #22228
- Default to public channel for watchOrderBook
- Remove 4000 limit
- Docstring
- better error when using private channel
carlosmiei
reviewed
May 6, 2024
ts/src/pro/okx.ts
Outdated
} | ||
} | ||
if ((depth === 'books-l2-tbt') || (depth === 'books50-l2-tbt')) { | ||
try { | ||
this.checkRequiredCredentials (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this try catch 'checkRequiredCredentials` can return without throwing
DEMO
|
kroitor
pushed a commit
that referenced
this pull request
May 6, 2024
* fix(okx): default to public watchOrderBook * cr fix --------- Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com> [ci skip]
DelAnt
pushed a commit
to DelAnt/ccxt
that referenced
this pull request
May 10, 2024
* fix(okx): default to public watchOrderBook * cr fix --------- Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com>
DelAnt
pushed a commit
to DelAnt/ccxt
that referenced
this pull request
May 10, 2024
* fix(okx): default to public watchOrderBook * cr fix --------- Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com> [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.