fix(future.py): add tests and fixes #22101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing issues:
Future exception was never retrieved
The only way to solve this I can think of is we would have refactor to track what futures are part of race_futures and which ones are not, to know which ones to reject and which ones to cancel. And then keep track of the race_futures seperately to throw an ExchangeClosedByUser in the case they all it's promises are cancelled. But this seems a large change that I'm not sure if we want to go into.
Test by running
npm run test-python-future
Test by running
python3 python/ccxt/pro/test/base/test_close.py