Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed NSNumber to NSDecimalNumber when retrieving doubles from db #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafek
Copy link

@rafek rafek commented Dec 14, 2014

This will allow for better precision = less rounding errors.

@ccgus
Copy link
Owner

ccgus commented Dec 15, 2014

Thanks for doing this. I don't want to change the behavior for a 2.x update of FMDB though- and swapping out classes behind the scenes does that. So, maybe for the next big release (3.0?) I'll add this in.

Do you have any tests where you can show NSNumber not being precise enough by any chance? If I can test and reproduce a failure, it's more likely to get added.

@kaala
Copy link

kaala commented Feb 10, 2015

I had a decimal precision problem, the column type I got is real.
this fixed the problematic value. but also created precision problem on another value.

I patched by using this code:

NSString *str=[self stringForColumnIndex:columnIdx];
returnValue = [NSDecimalNumber decimalNumberWithString:str];

@igorkulagin
Copy link

I would like to vote up this request.
Also NSNumber is superclass of NSDecimalNumber and existing implementations in 3rd-party apps should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants