Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP,ENH: sidebar context menu #342

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR shows a basic context menu when the user right-clicks on an element of the sidebar. It's another take on the suggestion described in #305. Plus other useful actions could eventually be added to the context menu:

output.mp4

@cbrnr
Copy link
Owner

cbrnr commented Mar 31, 2022

This is useful! Can you make it so that the context menu only appears when the mouse is over an actual entry? Right now you can click anywhere in the sidebar.

Also, closing a file would be a good candidate for a dedicated "X" (e.g. right-aligned next to the sidebar entry), which I'd prefer over a context menu entry. But if this is too difficult, having it in the context menu is certainly better than nothing.

@GuillaumeFavelier GuillaumeFavelier marked this pull request as draft March 31, 2022 16:01
@GuillaumeFavelier
Copy link
Contributor Author

Can you make it so that the context menu only appears when the mouse is over an actual entry?

I'll see if I can make it work like that. Otherwise, I'll try to add the right-aligned 'X' close button.

@GuillaumeFavelier GuillaumeFavelier changed the title ENH: sidebar context menu WIP,ENH: sidebar context menu Mar 31, 2022
@cbrnr
Copy link
Owner

cbrnr commented Dec 29, 2023

@GuillaumeFavelier do you want to continue working on this? We can skip the X button and only have a context menu, but it should only appear when right-clicking on an item. The menu could include two entries "Rename" and "Close" for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants