Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to stop and reenable the automatic scrolling of the text. #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jpsachse
Copy link

@jpsachse jpsachse commented Jun 8, 2015

I've added three functions to stop and reenable the automatic scrolling feature.

This is useful, when the label is out of view for some time. Otherwise, it might become visible and the text is scrolled to an arbitrary position.

@cbess
Copy link
Owner

cbess commented Aug 6, 2015

Interesting. I'll review the code.

@delannoyk
Copy link

Would love to see this feature coming!

@jpsachse
Copy link
Author

Is there anything that prevents you from merging this (by now) quite old pull request that I could resolve?

@cbess
Copy link
Owner

cbess commented Oct 26, 2015

Compared to other things I'm working on, this has low priority. Thanks for pinging me about it. I will make time to review/merge it this weekend.

@cbess
Copy link
Owner

cbess commented Oct 26, 2015

Also, from my initial review, a while back, I realized that I will have to rewrite your API. I think the API and naming of the proposed methods could be better. But, I will adopt most of the underlying logic. Thanks for the code.

@jpsachse
Copy link
Author

Okay, no worries :-)

Repository owner deleted a comment from DavideStagni Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants