Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Many midi devices that don't have velocity sensitivity usually send notes with velocity values like 64, 96 or 100 (out of 127). This means that those keypresses are not recognised by midimonster. 127 is rarely used as it'd correspond to maximum piano key velocity, which wouldn't sound musical, unlike less extreme values. This patch sets the threshold at 0.5 which fixes the problem for my Behringer FCB1010. Ideally it'd probably make sense to make the key velocity threshold configurable, but I'm not the best C programmer to do that.