Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove long import statement #7

Merged
merged 1 commit into from Oct 19, 2022
Merged

Conversation

dora1998
Copy link
Contributor

protobuf.js cli emits a import statement of Long type after 6.9.0 (protobufjs/protobuf.js#1166)
However, we remove all Long type references, so I added an implemention that removes this statement.

@dora1998 dora1998 self-assigned this Oct 18, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@wadackel wadackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :)
LGTM 👍

@wadackel wadackel merged commit 164ac0b into main Oct 19, 2022
@wadackel wadackel deleted the feat/remove-long-import branch October 19, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants