Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window connect separator #184

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MykhailoSukhostavets
Copy link

@MykhailoSukhostavets MykhailoSukhostavets commented Apr 3, 2024

Issue: #177

@MykhailoSukhostavets MykhailoSukhostavets changed the title Window connect separator Issue: #177 Window connect separator Apr 3, 2024
@vdbe
Copy link
Collaborator

vdbe commented Apr 8, 2024

There seems to be an issue with the background between the windows

set -g @catppuccin_status_background "#ff0000" with config:

@vdbe vdbe linked an issue Apr 8, 2024 that may be closed by this pull request
@vdbe
Copy link
Collaborator

vdbe commented Apr 9, 2024

I think you need to set window-status-style bg (and prbly also the active style) like done with status-style to get default working.

tmux/catppuccin.tmux

Lines 56 to 65 in 5ed4e8a

status_background=$(get_tmux_option "@catppuccin_status_background" "theme")
if [ "${status_background}" = "theme" ]; then
set status-bg "${thm_bg}"
else
if [ "${status_background}" = "default" ]; then
set status-style bg=default
else
set status-bg "${status_background}"
fi
fi

@MykhailoSukhostavets
Copy link
Author

Thank you, I will test it later.
(Also I still need to update logic when we fill number)

@MykhailoSukhostavets
Copy link
Author

MykhailoSukhostavets commented Apr 9, 2024

I think you need to set window-status-style bg (and prbly also the active style) like done with status-style to get default working.

Didn't work or I did smth wrong, I tried to play with logic like that:

      set-window-option -g window-status-style fg="#000000"
      set-window-option -g window-status-style bg="#000000"
      set-window-option -g window-status-current-style fg="#000000"
      set-window-option -g window-status-current-style bg="#000000"

Other than "default" should work fine
image

@vdbe
Copy link
Collaborator

vdbe commented Apr 18, 2024

Is there any possibility to reduce the line count of build_window_format it was bad before but this a 100 line switch statement with 4 almost identical cases/branches

Some patterns (for window_number_position blocks):

  • bg consists 1 color and default (always at the same place)
  • first 2 show_left always $thm_bg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Window connect seperator
2 participants