Add status page and table #175
Conversation
|
|
||
| $detail = optional_param('detail', '', PARAM_TEXT); // Show detailed info about one check only. | ||
|
|
||
| $url = '/report/status/status.php'; |
There was a problem hiding this comment.
This url means the check link and more info are going to report/status/status.php?xxx which doesn't exist, instead of report/status/index.php?xxx. Is this intended for future functionality or does it need to be updated?
There was a problem hiding this comment.
this should be admin/tool/heartbeat/status.php
There was a problem hiding this comment.
Tested that and it works, so +1 for changing it to /admin/tool/heartbeat/status.php
| get_string('status'), | ||
| get_string('check'), | ||
| get_string('summary'), | ||
| 'Exemption', | ||
| get_string('action'), | ||
| ]; | ||
| $table->colclasses = [ | ||
| 'rightalign status', | ||
| 'leftalign check', | ||
| 'leftalign summary', | ||
| 'leftalign exemption', | ||
| 'leftalign action', | ||
| ]; | ||
| $table->id = $this->type . 'reporttable'; | ||
| $table->attributes = ['class' => 'admintable ' . $this->type . 'report generaltable']; | ||
|
|
||
| foreach ($this->checks as $check) { | ||
| $ref = $check->get_ref(); | ||
| $result = $check->get_result(); | ||
| $component = $check->get_component(); | ||
| $actionlink = $check->get_action_link(); | ||
|
|
||
| $link = new \moodle_url($this->url, ['detail' => $ref]); | ||
|
|
||
| $row = []; | ||
| $row[] = $output->check_result($result); | ||
| $row[] = $output->action_link($link, $check->get_name()); | ||
|
|
||
| $row[] = $result->get_summary() | ||
| . '<br>' | ||
| . \html_writer::start_tag('small') | ||
| . $output->action_link($link, get_string('moreinfo')) | ||
| . \html_writer::end_tag('small'); |
There was a problem hiding this comment.
There's a couple of potential indenting issues here which were fixed in the following branch. Nothing serious so will depend on if you want to update it now or just wait until the later branch is merged in.
|
closing this in favor of 171 |
Pull request was closed
Pull request checks