Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deselectOption on deselecting the first list entry, if only first entry is selected #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Parama91
Copy link

An error occured on deselecting the last selected option, if first in list of options. After adding the missing ' in the function deselectOption to the command, deselection is working and footer is updating fine again.
New command: e("option[value='"+e(t).data("val")+"']",this.source).prop("selected",!1)

Add missing ' in the function "deselectOption" to the command e("option[value='"+e(t).data("val")+"']",this.source).prop("selected",!1). Now deselection is working without error.
@caseyWebb
Copy link
Owner

caseyWebb commented Oct 11, 2017

Make the changes in the src directory and re-run the build w/ npm run build. I didn't really know anything about node when I wrote this, so you'll need coffeescript installed globally.

I sincerely apologize for the coffeescript; I used to think it was a good idea — it's not. When I get some free time, I'd like to rewrite this in TypeScript.

@caseyWebb
Copy link
Owner

caseyWebb commented Oct 11, 2017

I see your fancy-shmancy first-time contributor badge up there — welcome! If you need/want any help, reach out to me on https://gitter.im/caseyWebb.

@Parama91
Copy link
Author

Thanks for the information! First pull request, first mistake 😄 . Will try to install coffeescript and re-run the build in the next few days, if i get enough time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants