Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arm docker support #938

Closed
wants to merge 2 commits into from
Closed

Conversation

WarlockFish
Copy link

build.sh shell rdedirect is invalid 。
add arm64 and armv7 docker, use qemu and compilation arm time is long(about 40 min ),because the yarn or node bug

@casbin-bot
Copy link
Contributor

@seriouszyx @ComradeProgrammer @Resulte please review

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2022

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Jul 31, 2022

@WarlockFish plz fix:

image

@WarlockFish WarlockFish changed the title add arm docker supper and fix invalid rdedirect feat: add arm docker supper Jul 31, 2022
@hsluoyz hsluoyz changed the title feat: add arm docker supper feat: add arm docker support Jul 31, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Aug 7, 2022

Hi @WarlockFish , what does this PR add? Does it add Arm-related image files to the Docker image to increase the image size? I'd like to know all side effects brought by this PR

/cc @Abingcbc

@ComradeProgrammer @wenxuan70

@WarlockFish
Copy link
Author

@hsluoyz it see like docker hub, i test tag v0.0.0 is ok in arm。the images for framework is separated 。

@hsluoyz
Copy link
Member

hsluoyz commented Aug 8, 2022

@WarlockFish so it will generate addtional images, right? I ask this because our DockerHub plan is limited in storage. If we take up too much space in DockerHub, Docker will throttle us or even block us before the next due date. You have added 2 new ARM images besides our own Linux image, so it has been enlarged by 2 times from now on for all releases just due to your scenario. I don't think this is OK for us. Can you try other solutions like forking this project and releasing to your own DockerHub account and subscription?

@WarlockFish
Copy link
Author

@hsluoyz ok,i will use my docker images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants