fix: reduce the length of token #1172
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seriouszyx @ComradeProgrammer @Resulte please review |
hsluoyz
force-pushed
the
master
branch
2 times, most recently
from
ce67879
to
67f3c5a
Compare
This was referenced Oct 4, 2022
hsluoyz
force-pushed
the
master
branch
2 times, most recently
from
3cbbe2c
to
6fb3e2c
Compare
hsluoyz
force-pushed
the
master
branch
2 times, most recently
from
87a507f
to
ca1b5fe
Compare
hsluoyz
force-pushed
the
master
branch
3 times, most recently
from
547317f
to
38da63e
Compare
hsluoyz
force-pushed
the
master
branch
3 times, most recently
from
0efd011
to
4c8648d
Compare
hsluoyz
force-pushed
the
master
branch
2 times, most recently
from
a655f25
to
3c30222
Compare
hsluoyz
force-pushed
the
master
branch
10 times, most recently
from
9941efe
to
463fa8b
Compare
hsluoyz
force-pushed
the
master
branch
5 times, most recently
from
af67dc2
to
988b26b
Compare
hsluoyz
force-pushed
the
master
branch
4 times, most recently
from
8911a11
to
5ec49dc
Compare
hsluoyz
force-pushed
the
master
branch
2 times, most recently
from
560cebf
to
d06d7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1170
Need to test various language/framework sdk, as it may cause some problems. For example, Jackson will set null by default if property is missing.
For no null-safety languages (like Java), we need to make sure sdk construct 3-rd party properties from null string to empty string. For has null-safety languages (like TypeScript), we can add nullable to property.