Updated cvx work vectors #3179
Open
Updated cvx work vectors #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and higher max_iter_eig limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3169
Changes local variable arrays in casadi_cvx to work vectors supplied to the function call. Avoids buffer overflow if the required array is too large.
This pull requests appears to break backward compatibility to load code generated with casadi 3.5.5 I assume this is because the work vectors in the code generated with casadi 3.5.5 is not of suitable size for the changes to casadi_cvx.
It also includes a test that still fails, code generation with main when calling convexify on a large strongly connected matrix (stack overflow?).