Make Python bindings thread-friendly #2442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable "pythonlogger" as it locks the GIL. This would cause the GIL to be locked for every line of console output from, e.g., IPOPT. - Wrap DM function calls in Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS so that the GIL is released during numeric CasADi function calls.
|
@jgillis FYI |
|
I understand DM function calls are not thread safe, but that the new Python calling API in #2433 would be. The Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS would then have to move there. |
jgillis
added a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be locked for every line of console output from, e.g., IPOPT.
so that the GIL is released during numeric CasADi function calls.