New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI for application management #184
base: main
Are you sure you want to change the base?
Conversation
36df0ba
to
cbbd342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
I found no reference to the chain the node is running? Is it expected to a multi-dapp node to work on multiple chains, of for a single chain? Anyway, I think some API endpoint (or response header) should expose details for the configuration of the node, the chainID being one of these details. GET /v1/status
{ "chainID": "123", "epochDuration": "68000", "applicationCount": 10, ...} |
No. It's single chain.
The process running the API will receive the same env variables as a node would receive. |
Application count is part of the API in the response of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
b2b5173
to
a5ce5f4
Compare
Rebased, squashed, renamed file. |
Added 204 to DELETE, in case it can be satisfied immediately. |
7ae3ced
to
12db9e3
Compare
So, will it be a sync request? Do you plan to remove the |
It will be a sync request. If times out the client would have to query the GET until it returns |
I see. I don't have strong opinions about the stopped, you can leave it if you want. |
|
1eaacf4
to
2a84f5d
Compare
Defines an openapi for application management of a (future) multi-application node.
It defines 4 endpoints: listing, adding, querying and removing.
Listing is paginated and has filtering based on status.
I used
application
instead ofdapp
. We're favoringapplication
in several locations including sunodo codebase and rollups-explorer codebase, because there are several tools that generate names based on that, and the term "DApp", or "dApp" does not behave well with those tools, often generating oddities liked-app
, ord_app
.