-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mongoose with Boost ASIO and support keep alive connections #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edubart
changed the title
refactor: use Boost ASIO instead of mongoose for TCP connections
Replace mongoose with Boost ASIO and support keep alive connections
May 13, 2024
edubart
force-pushed
the
refactor/boost-asio
branch
4 times, most recently
from
May 21, 2024 17:17
34567cb
to
da8fdd5
Compare
edubart
force-pushed
the
refactor/boost-asio
branch
from
May 27, 2024 18:13
da8fdd5
to
557753e
Compare
edubart
force-pushed
the
refactor/boost-asio
branch
from
May 28, 2024 11:49
557753e
to
31e790f
Compare
diegonehab
reviewed
May 28, 2024
diegonehab
reviewed
May 28, 2024
diegonehab
reviewed
May 28, 2024
edubart
force-pushed
the
refactor/boost-asio
branch
2 times, most recently
from
May 28, 2024 16:37
b3926b2
to
ab07d6c
Compare
edubart
force-pushed
the
refactor/boost-asio
branch
2 times, most recently
from
May 29, 2024 11:53
20e7a4d
to
7f51ee9
Compare
diegonehab
reviewed
May 29, 2024
diegonehab
reviewed
May 29, 2024
edubart
force-pushed
the
refactor/boost-asio
branch
from
May 29, 2024 16:41
60597f1
to
08f4af2
Compare
diegonehab
reviewed
May 31, 2024
diegonehab
reviewed
May 31, 2024
diegonehab
reviewed
May 31, 2024
diegonehab
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
edubart
force-pushed
the
refactor/boost-asio
branch
2 times, most recently
from
May 31, 2024 16:11
0472704
to
f3854ad
Compare
edubart
force-pushed
the
refactor/boost-asio
branch
from
June 3, 2024 14:32
f3854ad
to
dfaff6b
Compare
diegonehab
approved these changes
Jun 3, 2024
mpernambuco
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details:
select()
based implementation, so we have less chance of issues withfork()
.make dep
andmake downloads
were removedThis replaces:
This should close:
make dep
fails ifthird-party/downloads/
directory exists (even if it is empty) #157