Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSONRPC connection issues on edge cases #234

Merged
merged 2 commits into from Apr 30, 2024
Merged

Fix JSONRPC connection issues on edge cases #234

merged 2 commits into from Apr 30, 2024

Conversation

edubart
Copy link
Contributor

@edubart edubart commented Apr 24, 2024 •
edited

This will fix hard to happen problems when:

  • Doing shutdown() followed by a rebind() with JSON-RPC.
  • Connection TIME_WAIT accumulation when doing thousands of snapshots per second.

@edubart edubart self-assigned this Apr 24, 2024
@edubart edubart changed the title fix: close listening port immediately in JSONRPC shutdown Fix JSONRPC connection issues on edge cases Apr 24, 2024
@edubart edubart added the bug Something isn't working label Apr 24, 2024
@edubart edubart mentioned this pull request Apr 29, 2024
Closed
@edubart edubart merged commit cb99dba into main Apr 30, 2024
8 checks passed
@edubart edubart deleted the fix/jsonrpc-shutdown-rebind branch April 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpernambuco mpernambuco mpernambuco approved these changes

@diegonehab diegonehab diegonehab approved these changes

Assignees

@edubart edubart

Labels
bug Something isn't working
Projects
Machine Emulator SDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edubart @mpernambuco @diegonehab