Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC Episode #18

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

HPC Episode #18

wants to merge 23 commits into from

Conversation

multimeric
Copy link
Contributor

@multimeric multimeric commented Jul 10, 2023

  • Added an optional HPC episode, which uses Slurm as an example
  • This has been written using the current plan writing system. Once/if Code Re-Use #19 is merged, some of this will need re-writing to remove redundancy

@github-actions
Copy link

github-actions bot commented Jul 10, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/targets-workshop/compare/md-outputs..md-outputs-PR-18

The following changes were observed in the rendered markdown documents:

 basic-targets.md   |    8 +-
 branch.md          |   32 +-
 config.yaml (gone) |   87 ---
 files.md           |   22 +-
 files/functions.R  |  109 +++-
 hpc.md (new)       |   41 ++
 lifecycle.md       |   12 +-
 md5sum.txt         |   41 +-
 packages.md        |   12 +-
 renv.lock (gone)   | 1793 ----------------------------------------------------
 setup.md           |    2 +-
 11 files changed, 214 insertions(+), 1945 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-25 23:33:38 +0000

github-actions bot pushed a commit that referenced this pull request Jul 10, 2023
episodes/hpc.Rmd Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Show resolved Hide resolved
multimeric and others added 3 commits July 10, 2023 15:58
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 10, 2023
multimeric and others added 2 commits July 10, 2023 16:08
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 10, 2023
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
Copy link

@edoyango edoyango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments after having gone through the preceding episodes.

episodes/hpc.Rmd Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
multimeric and others added 3 commits July 20, 2023 10:41
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
@multimeric multimeric marked this pull request as ready for review July 25, 2023 02:04
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
episodes/hpc.Rmd Outdated Show resolved Hide resolved
episodes/hpc.Rmd Outdated Show resolved Hide resolved
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
@joelnitta
Copy link
Collaborator

joelnitta commented Sep 1, 2023

@multimeric thanks for your patience with #19, which has now been merged.

Is this PR basically ready to go in terms of content? There was a fair bit of discussion about it earlier, but seems to have quieted down recently (I personally don't use an HPC server so don't have much to add).

Also, in the OP you mentioned Once/if https://github.com/carpentries-incubator/targets-workshop/pull/19 is merged, some of this will need re-writing to remove redundancy. Does that still need to happen?

@multimeric
Copy link
Contributor Author

Yep, the content is all sorted, it's what I presented in July. But indeed I do need to rewrite some of this now that #19 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants