Adding some files needed for the interactive visual #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agitter
reviewed
Feb 15, 2021
There was a problem hiding this comment.
I'd like to use the existing directory organization if possible. The logistic regression example code is in ml-bio-workshop/assets/js/logit.js, for example. We already have a copy of d3.min.js there as well. The images could go in one of the existing directories used for images.
Is d3-annotation.js all your new code or is it derived from a third-party? Is the housing data simulated or from a real data source?
I suggest we wait to merge this until after the February workshop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.