Added compatibility with django-pagination #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, django-filter doesn't work well with django-pagination . There is a trick to do this [1], but this breaks the polimorphism of "object_list" (needed when use the same template sometimes with a FilterSet and some as a standard queryset). [1] carltongibson#13 Defining this couple of methods as a fallback to the inner qs, it works out of the box without custom django-pagination syntax.
| @@ -215,6 +215,14 @@ def __init__(self, data=None, queryset=None, prefix=None): | |||
| def __iter__(self): | |||
| for obj in self.qs: | |||
| yield obj | |||
|
|
|||
| def __len__(self): | |||
| # compatibility with django-pagination | |||
There was a problem hiding this comment.
Can you please remove this comment and the comment below? I think support len and getitem makes sense for more than just django-pagination.
|
Issue can be closed - fixed in #59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, django-filter doesn't work well with django-pagination . There is a trick to do this [1], but this breaks the polimorphism of "object_list" (needed when use the same template sometimes with a FilterSet and sometime with a standard queryset).
[1] #13
Defining this couple of methods as a fallback to the inner qs, it works out of the box without custom django-pagination syntax.