Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widgets.py #1588

Closed
wants to merge 2 commits into from
Closed

Conversation

zhaojiejoe
Copy link

No description provided.

make sure that the ret in the correct order
@zhaojiejoe zhaojiejoe changed the title Origin/patch 1 Update widgets.py Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #1588 (d90c5ff) into main (f38dcdd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1588   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          15       15           
  Lines        1271     1273    +2     
=======================================
+ Hits         1253     1255    +2     
  Misses         18       18           
Impacted Files Coverage Δ
django_filters/widgets.py 100.00% <100.00%> (ø)

@zhaojiejoe
Copy link
Author

sometimes we need the correct order in the query array. Set will change the order.

ret=[2022, 2021]
list(set(ret))
[2021, 2022]

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates the existing tests, which already pass. It doesn't look necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants