Deprecated Schema generations #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1574 +/- ##
==========================================
- Coverage 99.44% 98.58% -0.87%
==========================================
Files 15 15
Lines 1259 1271 +12
==========================================
+ Hits 1252 1253 +1
- Misses 7 18 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
cc @tfranzel |
carltongibson
force-pushed
the
deprecations
branch
from
ed7b2d7
to
b915c88
Compare
Add TestCase with fallback.
carltongibson
force-pushed
the
deprecations
branch
from
b915c88
to
01a83fb
Compare
carltongibson
force-pushed
the
deprecations
branch
from
01a83fb
to
06b04ed
Compare
|
Hey Carlton, sry I was unavailable for some time. This looks good. I ran our tests against the new release. We never enter those deprecated methods and so we should be safe. 👍 |
|
Hey @tfranzel — that's what I like to hear! 🎶 Thanks for all your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1432. Closes #1573.
Related deprecations fix:
Add TestCase with fallback.