Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Any" option to AllValuesFilter #134

Closed
wants to merge 2 commits into from

Conversation

alanjds
Copy link

@alanjds alanjds commented Jan 23, 2014

This adds the "Any" option to AllValuesFilter, as asked on #36 and mentioned on the roadmap (#75).

Used the option from django.db.models.fields.BLANK_CHOICE_DASH, that will be translated to _("All") if using the LinkWidget

@mazing
Copy link

mazing commented Aug 27, 2014

I really needed this 👍

@carltongibson
Copy link
Owner

Hi @alanjds — could you update this to latest develop? Lets see if those test failures disappear. (Thanks)

@chromakey
Copy link

@alanjds this was a god send, thank you. I manually patched for now, looks like it hasn't been integrated yet?

@carltongibson
Copy link
Owner

Hi @chromakey — No it's not merged yet. The tests are failing.

I'm half-hoping just updating to the latest develop will resolve the issue. I'd guess it'll be something simple if not.

Cleaning up the remaining pull requests and issues is on my list — this pr included. All contributions appreciated.

@mazing
Copy link

mazing commented Nov 20, 2014

When will it be merged?

@carltongibson
Copy link
Owner

Tests are still failing, so the short answer is when I get to it. If you fancy updating the PR and fixing the tests that would help

@carltongibson
Copy link
Owner

I'm planning a 0.9 release now. I've not milestoned this particular issue for that but if it does get updated, with maybe some docs too then it could go in.

@carltongibson
Copy link
Owner

Closing in favour of #261

@andriworld
Copy link

#261 doesn't seem to have fixed this

@rpkilby
Copy link
Collaborator

rpkilby commented Mar 3, 2017

Yep - this seems to be an issue with how AllValuesFIlter generates its choices. I'm working on a fix.

@andriworld
Copy link

Thanks for the quick reply! No rush, as I found a workaround using the related commits by alanjds

@rpkilby
Copy link
Collaborator

rpkilby commented Apr 8, 2017

Hi @andriworld - sorry for the long wait, a fix is pending in #680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants