Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize filter binding to parent #1182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Mar 5, 2020

Pulled this out of #1150, since it's relatively straightforward to review on its own.

In short, this does two things:

  • The filterset now calls a bind method, instead of setting attributes directly on the filter.
  • The filter's param/filterset attribute name is also provided. This isn't strictly required, but it's useful if a user want's to be able to inspect the data passed to the filterset.

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #1182 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
+ Coverage   99.44%   99.44%   +<.01%     
==========================================
  Files          15       15              
  Lines        1258     1260       +2     
==========================================
+ Hits         1251     1253       +2     
  Misses          7        7
Impacted Files Coverage Δ
django_filters/filters.py 100% <100%> (ø) ⬆️
django_filters/filterset.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91526ba...3f65939. Read the comment docs.

Base automatically changed from master to main March 3, 2021 08:48
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants