Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix descending choices building for OrderingFilter #1176

Closed
wants to merge 2 commits into from

Conversation

jock-tanner
Copy link

@jock-tanner jock-tanner commented Feb 26, 2020

Fixes #1175

@codecov-io
Copy link

Codecov Report

Merging #1176 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   99.43%   99.43%   +<.01%     
==========================================
  Files          15       15              
  Lines        1243     1244       +1     
==========================================
+ Hits         1236     1237       +1     
  Misses          7        7
Impacted Files Coverage Δ
django_filters/filters.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400469f...2fb5940. Read the comment docs.

@jock-tanner jock-tanner changed the title #1175 Fix descending choices building for OrderingFilter #1175 Feb 26, 2020
@jock-tanner jock-tanner changed the title Fix descending choices building for OrderingFilter #1175 Fix descending choices building for OrderingFilter Feb 26, 2020
@rpkilby
Copy link
Collaborator

rpkilby commented Mar 5, 2020

Hi @jock-tanner. I tried pushing a few changes to your branch, but was unable to. Closing in favor of #1183. Thanks!

@rpkilby rpkilby closed this Mar 5, 2020
@jock-tanner
Copy link
Author

@rpkilby OK now I see my timing with this PR was no good considering the upcoming OrderingFilter refactoring in #1118. Thank you for taking your time nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in descending choices building for OrderingFilter
3 participants