Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework ordering filter #1118

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Rework ordering filter #1118

wants to merge 10 commits into from
+580 −65

Commits on May 24, 2020

  1. Add OrderingFilterTests.test_ordering_with_nulls to lock down orderin… 

    …g behavior regarding nulls
    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    4c5e00e View commit details
    Browse the repository at this point in the history

  2. Initial push for reworked OrderingFilter 

    Closes carltongibson#1021
    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    5d781a2 View commit details
    Browse the repository at this point in the history

  3. Resolve errors reported by lint and isort

    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    db1986f View commit details
    Browse the repository at this point in the history

  4. Run isort

    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    e21ba2d View commit details
    Browse the repository at this point in the history

  5. Fix tests under Django 1.11 by defining custom F.__eq__ and OrderBy._… 

    …_eq__ operators
    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    25e130c View commit details
    Browse the repository at this point in the history

  6. Cover the case when ordering descriptor is specified as a list of mod… 

    …el fields
    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    36231d5 View commit details
    Browse the repository at this point in the history

  7. Correct a comment

    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    56f81cd View commit details
    Browse the repository at this point in the history

  8. In the updated OrderingFilter class, rename _params to params to matc… 

    …h the style of existing code
    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    964fa26 View commit details
    Browse the repository at this point in the history

  9. Remove if True which was probably used for debugging

    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    ee0e6ba View commit details
    Browse the repository at this point in the history

  10. Use a nullable DateTime model field to test OrderingFilter's handling… 

    … of nulls
    @earshinov
    earshinov committed May 24, 2020
    Configuration menu
    Copy the full SHA
    e192249 View commit details
    Browse the repository at this point in the history