Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in descending choices building for OrderingFilter #1175

Open
jock-tanner opened this issue Feb 26, 2020 · 0 comments · May be fixed by #1183
Open

Bug in descending choices building for OrderingFilter #1175

jock-tanner opened this issue Feb 26, 2020 · 0 comments · May be fixed by #1183

Comments

@jock-tanner
Copy link

I got a problem assigning custom labels to reverse ordering options with field_labels parameter. I think this method is incorrect in its descending = ... part. It looks up for -param instead of -field, as stated in the docs: «Keep in mind that the key is the field name, and not the exposed parameter name».

I have a fix for this issue, including an upgrade of the current test case with this issue in mind. I will provide it ASAP. If anything is wrong with my fix, please let me know. I'd like it to work for everybody, not just me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant