Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ROS2 tools build #7641

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

xavisolesoft
Copy link
Contributor

Description

Given that ROS2 tools are not used by CARLA ROS2 Native extension and ROS2 tools fail to build in some machine environments, makes sense to disable it as will be hard to fix and maintain it without any value of return now.

ROS2 Tools BuildFeatures

  • Discovery server: Discovery server fails to build in some machine environments and is not used by CARLA ROS2 Native. Discovery server consists on a centralized server to reduce the network overhead in the case of having huge number of ROS2 nodes, but this is not the case of current CARLA ROS2 Native implementation. For more details, see the next link: https://docs.ros.org/en/foxy/Tutorials/Advanced/Discovery-Server/Discovery-Server.html
  • Copies some python scripts used to debug ROS2 messages and discovery server to the release folder. This scripts can be also found in the fastdds source directory present in the CARLA build, so this debug scripts are not needed to be copied in the fastdds build as developers can get it from the fastdds source folder. Just makes sense to copy it in the case of distributing fastdds built libraries for development without the source code.

Where has this been tested?

  • Platform(s): Ubuntu 22.04
  • Python version(s): 3.10
  • Unreal Engine version(s): 5.3

Copy link

update-docs bot commented May 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@xavisolesoft xavisolesoft marked this pull request as ready for review May 14, 2024 08:17
@xavisolesoft xavisolesoft requested a review from a team as a code owner May 14, 2024 08:17
@xavisolesoft xavisolesoft linked an issue May 14, 2024 that may be closed by this pull request
@Blyron Blyron merged commit ee9fe78 into ue5-dev May 14, 2024
@delete-merged-branch delete-merged-branch bot deleted the xavisolesoft/Disable-ros2-tools-build branch May 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROS2: Fix ROS2 build when clang is the system default compiler
2 participants