Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go.mod #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: go.mod #191

wants to merge 1 commit into from

Conversation

redref
Copy link
Contributor

@redref redref commented Jun 1, 2023

Running go mod vendor modified go.mod.

Signed-off-by: Anthony BESCOND <anthony.bescond@kiln.fi>
@carina-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redref
To complete the pull request process, please assign fanhaouu
You can assign the PR to them by writing /assign @fanhaouu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redref
Copy link
Contributor Author

redref commented Jun 1, 2023

/assign @fanhaouu

@fanhaouu
Copy link
Member

fanhaouu commented Jun 4, 2023

why remove github.com/prometheus/procfs? you can run 'go mod why' or 'go mod graph'

@redref
Copy link
Contributor Author

redref commented Jun 6, 2023

WHen building docker file, we have an issue with :

 => ERROR [builder 5/6] RUN cd /workspace/github.com/carina-io/carina/cmd/carina-node && go build -ldflags="-X main.gitCommitID=`git rev-parse HEAD`" -gcflags '-N -l' -o /tmp/carina-node .                                            0.5s
------
 > [builder 5/6] RUN cd /workspace/github.com/carina-io/carina/cmd/carina-node && go build -ldflags="-X main.gitCommitID=`git rev-parse HEAD`" -gcflags '-N -l' -o /tmp/carina-node .:
#0 0.436 go: updates to go.mod needed, disabled by -mod=vendor
#0 0.436 	(Go version in go.mod is at least 1.14 and vendor directory exists.)
#0 0.436 	to update it:
#0 0.436 	go mod tidy
------
Dockerfile:13
--------------------
  11 |     # Build
  12 |     RUN echo Commit: `git log --pretty='%s%b%B' -n 1`
  13 | >>> RUN cd $WORKSPACE/cmd/carina-node && go build -ldflags="-X main.gitCommitID=`git rev-parse HEAD`" -gcflags '-N -l' -o /tmp/carina-node .
  14 |     RUN cd $WORKSPACE/cmd/carina-controller && go build -ldflags="-X main.gitCommitID=`git rev-parse HEAD`" -gcflags '-N -l' -o /tmp/carina-controller .
  15 |     
--------------------

Here the go mod why :

$ go mod graph | grep procfs
github.com/carina-io/carina github.com/prometheus/procfs@v0.7.3
github.com/prometheus/client_golang@v1.12.1 github.com/prometheus/procfs@v0.7.3
github.com/prometheus/procfs@v0.7.3 github.com/google/go-cmp@v0.5.4
github.com/prometheus/procfs@v0.7.3 golang.org/x/sync@v0.0.0-20201207232520-09787c993a3a
github.com/prometheus/procfs@v0.7.3 golang.org/x/sys@v0.0.0-20210124154548-22da62e12c0c
k8s.io/apiextensions-apiserver@v0.25.0 github.com/prometheus/procfs@v0.7.3
k8s.io/component-base@v0.25.0 github.com/prometheus/procfs@v0.7.3
sigs.k8s.io/controller-runtime@v0.11.1 github.com/prometheus/procfs@v0.6.0
github.com/prometheus/client_golang@v1.11.0 github.com/prometheus/procfs@v0.6.0
github.com/prometheus/procfs@v0.6.0 github.com/google/go-cmp@v0.5.4
github.com/prometheus/procfs@v0.6.0 golang.org/x/sync@v0.0.0-20201207232520-09787c993a3a
github.com/prometheus/procfs@v0.6.0 golang.org/x/sys@v0.0.0-20210124154548-22da62e12c0c
github.com/prometheus/client_golang@v1.7.1 github.com/prometheus/procfs@v0.1.3
github.com/prometheus/procfs@v0.1.3 github.com/google/go-cmp@v0.3.1
github.com/prometheus/procfs@v0.1.3 golang.org/x/sync@v0.0.0-20190911185100-cd5d95a43a6e
github.com/prometheus/procfs@v0.1.3 golang.org/x/sys@v0.0.0-20200106162015-b016eb3dc98e
github.com/prometheus/client_golang@v1.0.0 github.com/prometheus/procfs@v0.0.2
github.com/prometheus/common@v0.4.1 github.com/prometheus/procfs@v0.0.0-20181005140218-185b4288413d
github.com/prometheus/procfs@v0.0.2 golang.org/x/sync@v0.0.0-20181221193216-37e7f081c4d4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants