Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize on pointer events since they should work for both mobile and desktop #1253

Merged
merged 5 commits into from Apr 21, 2024

Conversation

captbaritone
Copy link
Owner

@captbaritone captbaritone commented Apr 21, 2024

Extra: Avoid selecting "text" when trying to tap double size mode clutter bar target

Test Plan

(Test on both iOS/Safari and Desktop/Chrome)

  • While playing a track, drag position bar. See that it continues to move after the fact
  • Drag balance, see that balance changes and marquee stops showing balance text after release
  • Toggle double size mode, see that while touching it, the marquee shows info about double size mode
  • Tapping shade mode playlist takes focus from other windows
  • Playlist and Milkdrop windows can be resized by dragging handle
  • Windows can be moved by dragging title bar

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for vigorous-lalande-5190c2 ready!

Name Link
🔨 Latest commit f5d09ef
🔍 Latest deploy log https://app.netlify.com/sites/vigorous-lalande-5190c2/deploys/66256b26bb39a60008fa13bc
😎 Deploy Preview https://deploy-preview-1253--vigorous-lalande-5190c2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 21, 2024

Size Change: -28 B (0%)

Total Size: 494 kB

Filename Size Change
./packages/webamp/built/webamp.bundle.min.js 316 kB -12 B (0%)
./packages/webamp/built/webamp.lazy-bundle.min.js 179 kB -16 B (0%)

compressed-size-action

@captbaritone captbaritone merged commit 823720f into master Apr 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant