Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings/ocaml: fix ARM64 -> AArch64 #2318

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

bindings/ocaml: fix ARM64 -> AArch64 #2318

wants to merge 1 commit into from

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Apr 9, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

For now just fixing the compilation without adding new architectures or changing the building system.

Test plan

  1. cd bindings/ocaml/ && make
  2. ./test_basic
  3. ./test_aarch64

Closing issues

First step to solve #985

@XVilka XVilka mentioned this pull request Apr 9, 2024
Open
2 tasks
@Rot127
Copy link
Collaborator

Rot127 commented Apr 10, 2024

Please add a build test to the CI.

@Rot127 Rot127 added AArch64 Arch ocaml bindings build & packaging Build system and packaging related labels Apr 10, 2024
@Rot127 Rot127 added this to the v6 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AArch64 Arch build & packaging Build system and packaging related ocaml bindings
Projects
Capstone V6 Plan
Status: In Progress
Milestone
v6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XVilka @Rot127