Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Increase clang minimum version to 14, use newly added Ubuntu 24.04 CI image to test clang 14 - 18 #2040

Merged
merged 3 commits into from
May 20, 2024
Merged

[build] Increase clang minimum version to 14, use newly added Ubuntu 24.04 CI image to test clang 14 - 18 #2040

merged 3 commits into from
May 20, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented May 15, 2024

This updates the clang version window we support. A few points to consider here:

  • There is no short-term need to merge this, but doing so would help us avoid breakage with modern clang versions. The Ubuntu 24.04 image is still in 'beta' state, but in my experience the 'release' CI runners aren't all that reliable either unfortunately.
  • clang 15 or 16 are now supported on Ubuntu oldstable and Debian oldoldstable, so the new version window should be widely supported. The Ubuntu 22.04 image has clang 15 as its highest version and the 24.04 image has clang 14 as its lowest version, so rolling forward by fewer than 3 versions would be non-trivial.

kentonv
kentonv reviewed May 15, 2024
View reviewed changes
c++/src/kj/common.h Outdated
// Technically this was only added to C++20 but Clang allows it for >= C++11 and spelunking the
// attributes manual indicates it first came in with Clang 9.
#if __cplusplus > 201703L || (__clang__ && __cplusplus >= 201103L)
// Technically this was only added to C++20 but Clang allows it for >= C++11.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we require C++20 anyway so we can probably remove this conditional?

@fhanau
[build] Roll bazel 7.0.0 : 7.1.2
dd2bdf8 
- Roll bazel_skylib => 1.6.1
@fhanau fhanau changed the title [DRAFT] [build] Increase clang minimum version to 14, use newly added Ubuntu 24.04 CI image to test clang 14 - 18 [build] Increase clang minimum version to 14, use newly added Ubuntu 24.04 CI image to test clang 14 - 18 May 20, 2024
@fhanau fhanau requested a review from mikea May 20, 2024 13:06
@fhanau fhanau marked this pull request as ready for review May 20, 2024 13:06
@fhanau
[build] Increase clang minimum version to 14, use newly added Ubuntu …
390d749 
…24.04 CI image to test clang 14 - 18

- Drop ninja dependency for Windows build, this was used in the past
  when building with prior MSVC versions.
@fhanau
Fix -Wmissing-field-initializers warnings with Clang 18
d059efd
@fhanau fhanau merged commit e074059 into v2 May 20, 2024
13 checks passed
@fhanau fhanau deleted the felix/roll-clang branch May 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentonv kentonv kentonv approved these changes

@mikea mikea Awaiting requested review from mikea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fhanau @kentonv