[nfc] Clean up recursive header dependencies #2039
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/header-cleanup
branch
3 times, most recently
from
400221f
to
8e78ad4
Compare
fhanau
force-pushed
the
felix/header-cleanup
branch
from
8e78ad4
to
f552a15
Compare
fhanau
commented
May 26, 2024
| @@ -5,9 +5,6 @@ | |||
|
|
|||
| #include <capnp/generated-header-support.h> | |||
| #include <kj/windows-sanity.h> | |||
| #if !CAPNP_LITE | |||
There was a problem hiding this comment.
Regenerated the header, the extra include directives are no longer being generated.
This should slightly improve compile speeds, especially under MSVC. To keep this change small this primarily affects headers, which should already allow us to eliminate many superfluous recursive includes. - Limit usage of intrin.h for MSVC which is generally large, describe what it is used for. - Drop some support for MSVC versions older than VS 2017 Update 9 (_MSC_VER 1916).
fhanau
force-pushed
the
felix/header-cleanup
branch
from
f552a15
to
0fb35b9
Compare
fhanau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should slightly improve compile speeds, especially under MSVC. To keep this change small this primarily affects headers, which should already allow us to eliminate many superfluous recursive includes.
Further potential to reduce recursive includes exists by refactoring async code so that coroutines are not always included, as well as isolating usage of large libc++ headers like <set> and <atomic>. I experimented with those and based on looking at preprocessed source code sizes in a more rigorous way this leads to larger improvements in include sizes, but the advantage in compile time is harder to evaluate.
This will likely require some include changes downstream which are still Work-In-Progress, but this should be final and ready for review.