-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new sync IO api #2015
new sync IO api #2015
Conversation
5920e22
to
3568a24
Compare
I think this is ready for review. I'll start working on downstream PRs meanwhile. |
3568a24
to
ab0ce88
Compare
6924142
to
d5f5953
Compare
Looks like the MSVC tests are failing. (#2024 fixed them at master, so presumably it's a new breakage.) Otherwise looks good. |
c201f68
to
e66c7e7
Compare
e66c7e7
to
6b13999
Compare
LGTM once CI is green. I'll leave it to someone else to actually hit approve tho. |
Windows build is fixed. I've opened downstream PRs that I will update now to the latest hash: |
6b13999
to
89b1d43
Compare
just a rebase |
This change reworks all synchronoush IO API in terms of ArrayPtr to be safer.
Read API now is:
and new write API supports multiple pieces from the get go: