Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lock blocking tracking #1944

Merged
merged 1 commit into from
May 13, 2024

Conversation

mikea
Copy link
Collaborator

@mikea mikea commented Feb 14, 2024

the feature was never really used downstream, and is removed from there.

@fhanau
Copy link
Collaborator

fhanau commented Feb 15, 2024

A few more things can be removed – c++/build/configure.bzl still has a track_lock_blocking variable and the Inherits from LockSourceLocation to perform an empty base class optimization when lock tracking... comment in c++/src/kj/mutex.h is obsolete.

the feature was never really used downstream, and is removed from there.
@mikea mikea force-pushed the maizatskyi/2024-02-14-cleanup_contention_walker branch from 4260b21 to 5e82b92 Compare May 13, 2024 16:59
@mikea mikea merged commit d0c1ad5 into v2 May 13, 2024
13 checks passed
@mikea mikea deleted the maizatskyi/2024-02-14-cleanup_contention_walker branch May 13, 2024 17:11
fhanau added a commit that referenced this pull request May 18, 2024
These are obsolete after #1944 and break `bazel cquery deps(//...)`
since the corresponding bool_flags are no longer available.
fhanau added a commit that referenced this pull request May 18, 2024
These are obsolete after #1944 and break `bazel cquery 'deps(//...)'`
since the corresponding bool_flags are no longer available.
fhanau added a commit that referenced this pull request May 18, 2024
These are obsolete after #1944 and break `bazel cquery 'deps(//...)'`
since the corresponding bool_flags are no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants