Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AsRef instead of Deref in NoAllocBufferSegments #475

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

dwrensha
Copy link
Member

@dwrensha dwrensha commented Jan 13, 2024

This follows the pattern in #474.

Note in particular that [u8; N] implements AsRef<[u8]> but does not implement Deref<Target=[u8]>.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (857b324) 51.85% compared to head (b5b7b7d) 51.80%.

Files Patch % Lines
capnp/src/serialize/no_alloc_buffer_segments.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   51.85%   51.80%   -0.05%     
==========================================
  Files          69       69              
  Lines       34137    34137              
==========================================
- Hits        17702    17685      -17     
- Misses      16435    16452      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwrensha dwrensha merged commit 0cf983d into master Jan 14, 2024
10 checks passed
@dwrensha dwrensha deleted the NoAllocBufferSegments-AsRef branch January 14, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant