-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create logo and add to Readme #1203
Conversation
@@ -1,4 +1,4 @@ | |||
# Async.js | |||
![Async Logo](https://raw.githubusercontent.com/caolan/async/master/logo/async-logo_readme.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to
![Async Logo](./logo/async-logo_readme.jpg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or did you make it absolute for npm
to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work... we need to access raw.githubusercontent.com/...
, doing a relative path access, will access github.com/caolan/logo/async-logo_readme.jpg
witch is an 404
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it absolute to work with NPM and also Github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pros: We could place easter eggs during christmas, and it would work everywere... ( \o/ )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://stackoverflow.com/a/36313391/1517919
But sounds good, I'd rather gaurentee it works on npm than fiddle with npm ignore stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's new, sounds good both ways.. but for NPM, it isn't for sure..
Oh @ivanseidel can you export one more logo, without the borders? (For the docs page) |
@megawac, should the logo exports be in I will export an .SVG, so that the resolution isn't a problem in the future, is that ok for you? |
Works for me, place it in master as just logo.svg |
Just did. I followed the pattern for naming ( |
Issue #975 led me to a sprint to create a logo, as async is an awesome and globally used library. Now, it's readme page will feel even more alive with a few colors 馃槂
/logo
folder. It's in.AI
format since.EPS
was really ruge (~5Mb).jpg
. It's URL should be swapped fromivanseidel/async
tocaolan/async
before merging.Note: If all ok, let me know in order to change the URL in the Readme.
Fixes #975