Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logo and add to Readme #1203

Merged
merged 8 commits into from Jun 29, 2016
Merged

Create logo and add to Readme #1203

merged 8 commits into from Jun 29, 2016

Conversation

ivanseidel
Copy link
Contributor

@ivanseidel ivanseidel commented Jun 29, 2016

Issue #975 led me to a sprint to create a logo, as async is an awesome and globally used library. Now, it's readme page will feel even more alive with a few colors 馃槂

  • Logo file was placed into /logo folder. It's in .AI format since .EPS was really ruge (~5Mb)
  • Readme header was created as .jpg. It's URL should be swapped from ivanseidel/async to caolan/async before merging.
  • Icons were generated to the doc site ( static doc site generation聽#1202 )

Note: If all ok, let me know in order to change the URL in the Readme.

Fixes #975

@ivanseidel ivanseidel mentioned this pull request Jun 29, 2016
@@ -1,4 +1,4 @@
# Async.js
![Async Logo](https://raw.githubusercontent.com/caolan/async/master/logo/async-logo_readme.jpg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to

![Async Logo](./logo/async-logo_readme.jpg)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or did you make it absolute for npm to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work... we need to access raw.githubusercontent.com/..., doing a relative path access, will access github.com/caolan/logo/async-logo_readme.jpg witch is an 404...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it absolute to work with NPM and also Github

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pros: We could place easter eggs during christmas, and it would work everywere... ( \o/ )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://stackoverflow.com/a/36313391/1517919
But sounds good, I'd rather gaurentee it works on npm than fiddle with npm ignore stuff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's new, sounds good both ways.. but for NPM, it isn't for sure..

@megawac megawac merged commit bccd316 into caolan:master Jun 29, 2016
@megawac
Copy link
Collaborator

megawac commented Jun 29, 2016

Oh @ivanseidel can you export one more logo, without the borders?

(For the docs page)

@ivanseidel
Copy link
Contributor Author

@megawac, should the logo exports be in master, or should we place it in the site branch?

I will export an .SVG, so that the resolution isn't a problem in the future, is that ok for you?

@megawac
Copy link
Collaborator

megawac commented Jun 29, 2016

Works for me, place it in master as just logo.svg

@ivanseidel
Copy link
Contributor Author

Just did. I followed the pattern for naming (async-logo.svg). This is good when you are trying to search something in the browser.. it gives some contextuality (if there are 321039123 logo.svg, you will know witch one is the one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants