Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New contributions #45

Merged
merged 2 commits into from Feb 5, 2024
Merged

New contributions #45

merged 2 commits into from Feb 5, 2024

Conversation

dcbr
Copy link

@dcbr dcbr commented Feb 1, 2024

What?

Fixes failing tests and lint checks.

Why?

As this project is the most active fork of Hopding/pdf-lib, I wondered if you would accept new contributions here? I'm mostly interested in extensions for PDF signing.
To start developing from a fresh clone of this repository, the changes in this PR were necessary to correctly run all tests and lint checks.

How?

Mostly using yarn upgrade, yarn add and yarn lint commands, plus some manual fixes.

Testing?

All tests run correctly now

New Dependencies?

No

Screenshots

N/A

Suggested Reading?

No

Anything Else?

N/A

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

@Sharcoux
Copy link
Collaborator

Sharcoux commented Feb 3, 2024

Thanks for your contribution.

We're going to test that and merge.

@dcbr
Copy link
Author

dcbr commented Feb 4, 2024

Ok awesome :) Glad to see there is some activity for this extremely useful library!
I also noticed this project still uses tslint, which has been deprecated for some years now. I tried to convert to eslint, but I am not a linter expert and this caused some non-trivial changes (for me). So if someone is more familiar with that matter, I think it would be a good follow-up change.

@Sharcoux
Copy link
Collaborator

Sharcoux commented Feb 5, 2024

Yes, we forked a project that was using a stack we're not so comfortable with. We'd like to slowly update it to a stack we know better.

@Sharcoux Sharcoux merged commit 314322f into cantoo-scribe:master Feb 5, 2024
1 check passed
@Sharcoux
Copy link
Collaborator

Sharcoux commented Feb 5, 2024

Released in 1.20.3
Sorry for the mess in the repo. Was my first time trying to use the conflict resolution tool built in github and that didn't go well ^^"
Thanks for your contribution. ❤️

@dcbr
Copy link
Author

dcbr commented Feb 6, 2024

No problem, thanks for the quick release! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants