Cleanup iframe first to prevent memory leaks, see niklasvh#1609

cantoo-scribe · Aug 31, 2023 · 749cdcd · 749cdcd
1 parent df4c328
commit 749cdcd
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/src/dom/document-cloner.ts b/src/dom/document-cloner.ts
@@ -220,7 +220,7 @@ export class DocumentCloner {
             clonedCanvas.width = canvas.width;
             clonedCanvas.height = canvas.height;
             const ctx = canvas.getContext('2d');
-            const clonedCtx = clonedCanvas.getContext('2d', { willReadFrequently: true });
+            const clonedCtx = clonedCanvas.getContext('2d', {willReadFrequently: true});
             if (clonedCtx) {
                 if (!this.options.allowTaint && ctx) {
                     clonedCtx.putImageData(ctx.getImageData(0, 0, canvas.width, canvas.height), 0, 0);
@@ -479,10 +479,24 @@ export class DocumentCloner {
     }
 
     static destroy(container: HTMLIFrameElement): boolean {
+        try {
+            // Clear the iframe's content
+            container.src = 'about:blank';
+
+            // Optionally allow the browser to handle garbage collection
+            if (container.contentWindow) {
+                container.contentWindow.document.open();
+                container.contentWindow.document.write('');
+                container.contentWindow.document.close();
+            }
+        } catch {}
+
+        // Remove the iframe from the DOM
         if (container.parentNode) {
             container.parentNode.removeChild(container);
             return true;
         }
+
         return false;
     }
 }